Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes water/mop intensity name/code handling for devices that report “water slide mode” (slider-based intensity), aligning water_box_mode codes with the correct user-facing strings and adding regression coverage.
Changes:
- Add explicit water-slide code→mode mapping (including
200 -> off) and a helper to buildwater_mode_mappingfeature-aware. - Update
StatusTrait.water_mode_mappingto use the feature-aware mapping helper. - Add a unit test validating slider-mode mappings and option ordering.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/devices/traits/v1/test_status.py |
Adds regression test asserting correct slide-mode code→string mapping and options list. |
roborock/devices/traits/v1/status.py |
Switches water_mode_mapping to use the new feature-aware mapping helper. |
roborock/data/v1/v1_clean_modes.py |
Introduces WATER_SLIDE_MODE_MAPPING and get_water_mode_mapping(), and updates slide-mode water options to include OFF. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some vacs have a slider instead of the normal selection. This should fix the problem.
home-assistant/core#164831